Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial: Chapter 1.1 - SwiftUI / Building a Simple Todo List UI #94

Merged
merged 14 commits into from
Mar 13, 2023
Merged

Tutorial: Chapter 1.1 - SwiftUI / Building a Simple Todo List UI #94

merged 14 commits into from
Mar 13, 2023

Conversation

peterfriese
Copy link
Owner

@peterfriese peterfriese commented Mar 9, 2023 •
edited
Loading

@peterfriese peterfriese added the tutorial Interactive DocC tutorial label Mar 9, 2023
@peterfriese peterfriese marked this pull request as ready for review March 9, 2023 17:00
@peterfriese peterfriese self-assigned this Mar 9, 2023
@marinacoelho
Copy link
Collaborator

This is great! I did all the steps in the tutorial, and the code works flawlessly.
Love the diagrams, the gifs, and the focus on user experience (the FocusableField step is very nice and well explained).
On another note, I noticed that a few Sections don't have the header image - is this something I can help you with?

ncooke3
ncooke3 approved these changes Mar 13, 2023
View reviewed changes
Copy link

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff @peterfriese! Pretty much all of the feedback I left is optional. I'm sure it's a lot of work to even rename APIs given the multiple code snippets, screenshots, and tutorial writeup so I'll leave it up to you to decide if a suggestion is worth implementing. 🙂

buildDocs.sh Outdated Show resolved Hide resolved
buildDocs.sh Outdated Show resolved Hide resolved
buildDocs.sh Outdated Show resolved Hide resolved
...tSo.docc/Resources/building-a-simple-todo-list-ui/code/building-todo-ui-reminder-01-03.swift Show resolved Hide resolved
...tSo.docc/Resources/building-a-simple-todo-list-ui/code/building-todo-ui-reminder-01-02.swift Outdated Show resolved Hide resolved
...mple-todo-list-ui/code/building-todo-ui-reminder-05-contentview-present-addreminder-04.swift Show resolved Hide resolved
...uilding-a-simple-todo-list-ui/code/building-todo-ui-reminder-06-addreminder-brushup-02.swift Outdated Show resolved Hide resolved
code/frontend/MakeItSo/MakeItSo/MakeItSo.docc/Tutorials/Building a simple todo list UI.tutorial Outdated Show resolved Hide resolved
code/frontend/MakeItSo/MakeItSo/MakeItSo.docc/Tutorials/Building a simple todo list UI.tutorial Outdated Show resolved Hide resolved
code/frontend/MakeItSo/MakeItSo/MakeItSo.docc/Tutorials/Building a simple todo list UI.tutorial Outdated Show resolved Hide resolved
peterfriese and others added 5 commits March 13, 2023 18:10
@peterfriese @ncooke3
🔨 Update buildDocs.sh
932ae74 
Co-authored-by: Nick Cooke <[email protected]>
@peterfriese @ncooke3
🔨 Update buildDocs.sh
4eac8f7 
Co-authored-by: Nick Cooke <[email protected]>
@peterfriese @ncooke3
🔨 Update buildDocs.sh
238bd4f 
Co-authored-by: Nick Cooke <[email protected]>
@peterfriese @ncooke3
✏️ Typo
d83aa34 
Co-authored-by: Nick Cooke <[email protected]>
@peterfriese @ncooke3
📝 Link to Apple's docs
9a86100 
Co-authored-by: Nick Cooke <[email protected]>
@peterfriese peterfriese mentioned this pull request Mar 23, 2023
Open
@peterfriese
Copy link
Owner Author

This is great! I did all the steps in the tutorial, and the code works flawlessly. Love the diagrams, the gifs, and the focus on user experience (the FocusableField step is very nice and well explained). On another note, I noticed that a few Sections don't have the header image - is this something I can help you with?

Thanks for the review! I added all of the missing images, and it looks much better now :-)

@peterfriese
Copy link
Owner Author

Awesome stuff @peterfriese! Pretty much all of the feedback I left is optional. I'm sure it's a lot of work to even rename APIs given the multiple code snippets, screenshots, and tutorial writeup so I'll leave it up to you to decide if a suggestion is worth implementing. 🙂

Thanks for the review! It was less work to make those changes than I expected.

@peterfriese peterfriese merged commit b2a71eb into tutorial/main Mar 13, 2023
@peterfriese peterfriese deleted the tutorial/develop/01-swiftui/01-building-a-simple-todo-list-ui branch March 13, 2023 18:49
@peterfriese peterfriese restored the tutorial/develop/01-swiftui/01-building-a-simple-todo-list-ui branch May 17, 2023 13:51
@peterfriese peterfriese changed the title Tutorial: SwiftUI / Building a Simple Todo List UI Tutorial: Chapter 1.1 - SwiftUI / Building a Simple Todo List UI May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashishpatil-g aashishpatil-g aashishpatil-g left review comments

@ncooke3 ncooke3 ncooke3 approved these changes

@marinacoelho marinacoelho marinacoelho left review comments

@thereallee thereallee Awaiting requested review from thereallee

Assignees

@peterfriese peterfriese

Labels
tutorial Interactive DocC tutorial
Projects
MakeItSo Codelab
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterfriese @marinacoelho @ncooke3 @aashishpatil-g